Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return conflicting schemas as part of error. #4857

Closed

Conversation

NullHypothesis
Copy link

This makes it easier for the user to figure out what exactly is in conflict.

This makes it easier for the user to figure out what exactly is in
conflict.
Copy link

CLA Not Signed

@NullHypothesis
Copy link
Author

For context, see the problems that folks (including myself) had in issue #2341.

@dmathieu
Copy link
Member

dmathieu commented Jan 29, 2024

You will need to sign the CLA and add a changelog entry.
It's also surprising no test failed with this change. Maybe add one?

@MrAlias
Copy link
Contributor

MrAlias commented Jan 29, 2024

Please also add a changelog entry

@MrAlias MrAlias added the blocked:CLA Waiting on CLA to be signed before progress can be made label Jan 29, 2024
@MrAlias
Copy link
Contributor

MrAlias commented Feb 5, 2024

Superseded by #4876

@MrAlias MrAlias closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked:CLA Waiting on CLA to be signed before progress can be made
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants