example/dice: Do not use semconv #4849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
dmathieu
approved these changes
Jan 24, 2024
MrAlias
approved these changes
Jan 24, 2024
dashpole
reviewed
Jan 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4849 +/- ##
=====================================
Coverage 82.3% 82.3%
=====================================
Files 226 226
Lines 18557 18557
=====================================
+ Hits 15286 15288 +2
+ Misses 2983 2981 -2
Partials 288 288 |
dashpole
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Per #4846 (comment)
Supersedes #4846
What
Use simply
resource.Default()and setOTEL_RESOURCE_ATTRIBUTESinstead of usingresource.NewWithAttributesto mitigate the "resource merge conflict" runtime error that the users encounter have when bumping OTel Go when they are using the existing "getting started" example (https://opentelemetry.io/docs/languages/go/getting-started/#initialize-the-opentelemetry-sdk).A PR to update https://opentelemetry.io/docs/languages/net/automatic/getting-started/ will be created as a follow-up to this PR.
Related to #2341
PTAL @chalin @svrnm