Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache instruments so repeatedly creating identical instruments doesn't leak memory #4820

Merged
merged 6 commits into from
Jan 24, 2024

Merge branch 'main' into duplicate_instruments

55829b3
Select commit
Loading
Failed to load commit list.
Merged

Cache instruments so repeatedly creating identical instruments doesn't leak memory #4820

Merge branch 'main' into duplicate_instruments
55829b3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 24, 2024 in 0s

82.3% (+0.0%) compared to cef39a1

View this Pull Request on Codecov

82.3% (+0.0%) compared to cef39a1

Details

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (cef39a1) 82.3% compared to head (55829b3) 82.3%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4820   +/-   ##
=====================================
  Coverage   82.3%   82.3%           
=====================================
  Files        226     226           
  Lines      18481   18557   +76     
=====================================
+ Hits       15222   15286   +64     
- Misses      2973    2983   +10     
- Partials     286     288    +2     
Files Coverage Δ
sdk/metric/cache.go 100.0% <100.0%> (ø)
sdk/metric/meter.go 90.4% <81.6%> (-2.2%) ⬇️

... and 1 file with indirect coverage changes