Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baggage: Improve performance #4743

Merged
merged 26 commits into from
Dec 14, 2023
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gofumpt
pellared authored Dec 8, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit ad00a1209cb29f3825451aeda7fe3a6a106d7f90
1 change: 0 additions & 1 deletion baggage/baggage.go
Original file line number Diff line number Diff line change
@@ -560,11 +560,10 @@
return
}


if s[index] != keyValueDelimiter[0] {
MadVikingGod marked this conversation as resolved.
Show resolved Hide resolved
// Bad key-value delimiter.
pellared marked this conversation as resolved.
Show resolved Hide resolved
return
}

Check warning on line 566 in baggage/baggage.go

Codecov / codecov/patch

baggage/baggage.go#L564-L566

Added lines #L564 - L566 were not covered by tests

// Attempting to parse the value.
index = skipSpace(s, index+1)