Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs Bridge API prototype #4725

Closed
wants to merge 107 commits into from
Closed

Logs Bridge API prototype #4725

wants to merge 107 commits into from

Commits on Nov 17, 2023

  1. Add empty design doc

    @pellared
    pellared committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    a6f19fe View commit details
    Browse the repository at this point in the history

  2. Init Logs Bridge API design

    @pellared
    pellared committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    c8fcf28 View commit details
    Browse the repository at this point in the history

  3. Document the design

    @pellared
    pellared committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    e48ae14 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    31c755f View commit details
    Browse the repository at this point in the history

  2. Add Rationale

    @pellared
    pellared committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    cd39d63 View commit details
    Browse the repository at this point in the history

  3. Move design doc closer to the code

    @pellared
    pellared committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    4578694 View commit details
    Browse the repository at this point in the history

  4. Cleanup

    @pellared
    pellared committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    fbd656f View commit details
    Browse the repository at this point in the history

  5. Cleanup

    @pellared
    pellared committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    9d9f10b View commit details
    Browse the repository at this point in the history

  6. Fix typo

    @pellared
    pellared committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    55bad1e View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: David Ashpole <[email protected]>
    @pellared @dashpole
    pellared and dashpole authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    249f4ed View commit details
    Browse the repository at this point in the history

  8. Clairfy RecordOption

    @pellared
    pellared committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    33a8aca View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. document fields that optimize attrs

    @pellared
    pellared committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2e3587c View commit details
    Browse the repository at this point in the history

  2. Add missing parenthesis

    @pellared
    pellared committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f19f0c8 View commit details
    Browse the repository at this point in the history

  3. Record and NewRecord is needed for SDK

    @pellared
    pellared committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    5456b9d View commit details
    Browse the repository at this point in the history

  4. Add usage examples

    @pellared
    pellared committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    4365860 View commit details
    Browse the repository at this point in the history

  5. Document Rejected Alternative: Reuse slog

    @pellared
    pellared committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    892ee8f View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Logger.Emit with record as argument

    @pellared
    pellared committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    f288cf2 View commit details
    Browse the repository at this point in the history

  2. Document Logger.Emit extensibility

    @pellared
    pellared committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    c0a795b View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Remy Chantenay <[email protected]>
    @pellared @remychantenay
    pellared and remychantenay authored Nov 24, 2023
    Configuration menu
    Copy the full SHA
    2704436 View commit details
    Browse the repository at this point in the history

  2. Write prototype implementation and benchmarks

    @pellared
    pellared committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    a718f69 View commit details
    Browse the repository at this point in the history

  3. Add missing vanity import

    @pellared
    pellared committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    700c91f View commit details
    Browse the repository at this point in the history

  4. gofumpt

    @pellared
    pellared committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    2e8403e View commit details
    Browse the repository at this point in the history

  5. Add TODO comments

    @pellared
    pellared committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    441cde8 View commit details
    Browse the repository at this point in the history

  6. Add copywrite header and fix for Go 1.20

    @pellared
    pellared committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    de09ce6 View commit details
    Browse the repository at this point in the history

  7. refactor

    @pellared
    pellared committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    dad0503 View commit details
    Browse the repository at this point in the history

  8. Update design

    @pellared
    pellared committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    c43bd51 View commit details
    Browse the repository at this point in the history

  9. Update design

    @pellared
    pellared committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    19438ca View commit details
    Browse the repository at this point in the history

  10. Rejected Alternative: Passing struct as parameter to LoggerProvider.L… 

    …ogger
    @pellared
    pellared committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    d4896f6 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    cf10dd0 View commit details
    Browse the repository at this point in the history

  2. Add go.opentelemetry.io/otel/log/benchmark module

    @pellared
    pellared committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ddcdbda View commit details
    Browse the repository at this point in the history

  3. Add slog.Handler naive implementation

    @pellared
    pellared committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    ca5bfb7 View commit details
    Browse the repository at this point in the history

  4. go mod tidy

    @pellared
    pellared committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    21ca157 View commit details
    Browse the repository at this point in the history

  5. Add logr.LogSink naive implementation

    @pellared
    pellared committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    0d9c335 View commit details
    Browse the repository at this point in the history

  6. Update design

    @pellared
    pellared committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    1c3776b View commit details
    Browse the repository at this point in the history

  7. gofumpt

    @pellared
    pellared committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    5bb9801 View commit details
    Browse the repository at this point in the history

  8. Refactor slogHandler

    @pellared
    pellared committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    7084df2 View commit details
    Browse the repository at this point in the history

  9. Export AttributesInlineCount

    @pellared
    pellared committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    3b8a68c View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    44e01f8 View commit details
    Browse the repository at this point in the history

  2. Rename Record.Attributes to Record.WalkAttributes

    @pellared
    pellared committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    e7b8c7a View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    d19ebad View commit details
    Browse the repository at this point in the history

  2. Unexport AttributesInlineCount

    @pellared
    pellared committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    ba2903a View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @pellared
    pellared committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    6443d19 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b170245 View commit details
    Browse the repository at this point in the history

  2. Ignore request cancelation

    @pellared
    pellared committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    21bea0f View commit details
    Browse the repository at this point in the history

  3. Encapsulate Record fields

    @pellared
    pellared committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    c8b3f05 View commit details
    Browse the repository at this point in the history

  4. Fix tests

    @pellared
    pellared committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    a8ba6be View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    60a4e45 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    b60433a View commit details
    Browse the repository at this point in the history

  2. fix typo

    @pellared
    pellared committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    689faff View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    7f299ff View commit details
    Browse the repository at this point in the history

  2. Rejected Alternative: Logger.WithAttributes

    @pellared
    pellared committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9f9acaf View commit details
    Browse the repository at this point in the history

  3. Fix MD009/no-trailing-spaces

    @pellared
    pellared committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9deedde View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    ecb503a View commit details
    Browse the repository at this point in the history

  2. Make parallel benchmarks

    @pellared
    pellared committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    445bae1 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Dec 19, 2023
    Configuration menu
    Copy the full SHA
    cd5a898 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into logs-design

    @pellared
    pellared authored Dec 19, 2023
    Configuration menu
    Copy the full SHA
    cd8217a View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Record attributes as field and use sync.Pool for reducing allocations

    @pellared
    pellared authored Dec 22, 2023
    Configuration menu
    Copy the full SHA
    977f3d7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into logs-design

    @pellared
    pellared authored Dec 22, 2023
    Configuration menu
    Copy the full SHA
    2d161ca View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Dec 27, 2023
    Configuration menu
    Copy the full SHA
    11e232c View commit details
    Browse the repository at this point in the history

  2. go mod tidy

    @pellared
    pellared committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    033e2e9 View commit details
    Browse the repository at this point in the history

  3. Trace contextg correlation design

    @pellared
    pellared committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    8c8f7ab View commit details
    Browse the repository at this point in the history

  4. writerLogger and slogHandler handle trace context

    @pellared
    pellared committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    a79b08f View commit details
    Browse the repository at this point in the history

  5. go mod tidy

    @pellared
    pellared committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    4be490b View commit details
    Browse the repository at this point in the history

  6. logrSink handle trace context

    @pellared
    pellared committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    3552368 View commit details
    Browse the repository at this point in the history

  7. Refine API implementation section

    @pellared
    pellared committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    3fbebee View commit details
    Browse the repository at this point in the history

  8. Fix grammar

    @pellared
    pellared committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    8e25e81 View commit details
    Browse the repository at this point in the history

  9. Move log/benchmark to log/internal

    @pellared
    pellared committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    321a049 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    2d62729 View commit details
    Browse the repository at this point in the history

  2. Update log package

    @pellared
    pellared committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a0bc4b8 View commit details
    Browse the repository at this point in the history

  3. go mod tidy

    @pellared
    pellared committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f6a2308 View commit details
    Browse the repository at this point in the history

  4. Remove DESIGN.md

    @pellared
    pellared committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    b780472 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Jan 16, 2024
    Configuration menu
    Copy the full SHA
    8eb2fab View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Add Severity[Level]1 consts

    @pellared
    pellared committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d832817 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Record attributes based on slog.Record (#6)

    @pellared
    pellared authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    f78cbec View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into logs-design

    @pellared
    pellared authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    1a8b1c5 View commit details
    Browse the repository at this point in the history

  3. go mod tidy

    @pellared
    pellared committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    6730f06 View commit details
    Browse the repository at this point in the history

  4. The caller must not subsequently mutate the record passed to Emit

    @pellared
    pellared committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    d114464 View commit details
    Browse the repository at this point in the history

  5. Refine Emit docs

    @pellared
    pellared committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    f08ebbf View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into logs-design

    @pellared
    pellared authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    d665181 View commit details
    Browse the repository at this point in the history

  7. go mod tidy

    @pellared
    pellared committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    a116609 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Handle structured body and attributes (#7)

    @pellared
    pellared authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    5d8c58f View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    3131463 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Record with pointer receivers only (#8)

    @pellared
    pellared authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    ecc26bc View commit details
    Browse the repository at this point in the history

  2. As[Type] Value methods

    @pellared
    pellared committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    2778c55 View commit details
    Browse the repository at this point in the history

  3. Use stringer for enum types

    @pellared
    pellared committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    68d99a8 View commit details
    Browse the repository at this point in the history

  4. Revert Makefile changes

    @pellared
    pellared committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e5dc7cf View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    4b96c4d View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    4084475 View commit details
    Browse the repository at this point in the history

  2. Fix Severity.String

    @pellared
    pellared committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d4d4274 View commit details
    Browse the repository at this point in the history

  3. TestKind

    @pellared
    pellared committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    91358b4 View commit details
    Browse the repository at this point in the history

  4. Refactor Value.String

    @pellared
    pellared committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    b90eca9 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Remove KeyValue.Invalid

    @pellared
    pellared committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a02b8ea View commit details
    Browse the repository at this point in the history

  2. Update AddAttributes

    @pellared
    pellared committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a8a1b7e View commit details
    Browse the repository at this point in the history

  3. Remove header

    @pellared
    pellared committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    c4a2209 View commit details
    Browse the repository at this point in the history

  4. Update comment

    @pellared
    pellared committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    45cfdcb View commit details
    Browse the repository at this point in the history

  5. Refine comment

    @pellared
    pellared committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    b55e22e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into logs-design

    @pellared
    pellared authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    aa3b222 View commit details
    Browse the repository at this point in the history

  7. go mod tidy

    @pellared
    pellared committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    4dccab0 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'logs-design' of https://github.com/pellared/opentelemet… 

    …ry-go into logs-design
    @pellared
    pellared committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    4e2e5e3 View commit details
    Browse the repository at this point in the history

  9. Refactor Severity to not use iota

    @pellared
    pellared committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a8f265c View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Merge branch 'main' into logs-design

    @pellared
    pellared authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    f8c46f1 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Remove Record.Clone as it is not necessary

    @pellared
    pellared committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    b996e00 View commit details
    Browse the repository at this point in the history

  2. Refine KeyValue docs

    @pellared
    pellared committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ed67f01 View commit details
    Browse the repository at this point in the history

  3. Remove unused attrsSlice

    @pellared
    pellared committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    5851ead View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into logs-design

    @pellared
    pellared authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    273a964 View commit details
    Browse the repository at this point in the history

  5. go mod tidy

    @pellared
    pellared committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e89444d View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. value does not panic and change List to Slice

    @pellared
    pellared committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    147762f View commit details
    Browse the repository at this point in the history