Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move readFile and execCommand to seperate files #4015

Merged
merged 6 commits into from
Apr 27, 2023

Conversation

pellared
Copy link
Member

Fixes #3972

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #4015 (f4ab24c) into main (15d6ba2) will increase coverage by 0.0%.
The diff coverage is 0.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4015   +/-   ##
=====================================
  Coverage   82.1%   82.2%           
=====================================
  Files        175     176    +1     
  Lines      13065   13058    -7     
=====================================
+ Hits       10736   10738    +2     
+ Misses      2108    2099    -9     
  Partials     221     221           
Impacted Files Coverage Δ
sdk/resource/host_id.go 97.4% <ø> (+24.3%) ⬆️
sdk/resource/host_id_readfile.go 0.0% <0.0%> (ø)

... and 1 file with indirect coverage changes

@MrAlias MrAlias merged commit 180b355 into open-telemetry:main Apr 27, 2023
@pellared pellared deleted the inline-nolint branch November 17, 2023 09:01
@XSAM XSAM added this to the Old Untracked PRs milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore moving readFile to host_id_bsd.go
5 participants