Guard zero value Set methods #3957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
bug
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3957 +/- ##
=======================================
+ Coverage 81.7% 82.0% +0.3%
=======================================
Files 171 171
Lines 12951 12951
=======================================
+ Hits 10592 10631 +39
+ Misses 2136 2100 -36
+ Partials 223 220 -3
|
MrAlias
force-pushed
the
guard-set-methods
branch
from
225320e to
5057813
Compare
hanyuancheung
approved these changes
Apr 1, 2023
pellared
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zero value
Setwill panic ifGet,HasValue, orValueare called. This is not strictly a bug given there is aNewSetfunction that ensures this value ofSetis never returned. However, adding these small checks help prevent users from introducing panics.