Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add WithAttribute methods for metric measurement operations with attributes #3955

Closed
wants to merge 9 commits into from

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 31, 2023

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #3955 (6f4fa65) into main (271df1d) will increase coverage by 0.0%.
The diff coverage is 93.9%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3955   +/-   ##
=====================================
  Coverage   81.7%   81.8%           
=====================================
  Files        171     171           
  Lines      12950   12982   +32     
=====================================
+ Hits       10585   10621   +36     
+ Misses      2142    2138    -4     
  Partials     223     223           
Impacted Files Coverage Δ
metric/instrument/asyncfloat64.go 100.0% <ø> (ø)
metric/instrument/asyncint64.go 100.0% <ø> (ø)
metric/instrument/syncfloat64.go 100.0% <ø> (ø)
metric/instrument/syncint64.go 100.0% <ø> (ø)
sdk/metric/meter.go 88.3% <66.6%> (-1.3%) ⬇️
internal/global/instruments.go 64.0% <100.0%> (+3.1%) ⬆️
metric/noop/noop.go 100.0% <100.0%> (ø)
sdk/metric/instrument.go 96.1% <100.0%> (+0.1%) ⬆️

... and 3 files with indirect coverage changes

@MrAlias
Copy link
Contributor Author

MrAlias commented Apr 7, 2023

#3971

@MrAlias MrAlias closed this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant