-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Version func to otel/sdk #3949
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3949 +/- ##
=====================================
Coverage 81.7% 81.7%
=====================================
Files 170 171 +1
Lines 12949 12950 +1
=====================================
+ Hits 10588 10591 +3
+ Misses 2138 2136 -2
Partials 223 223
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a distinct version.go
for each module? I believe that's what we've done in contrib and rely on multimod to manage them.
SGTM. The only other place the
I could see that being split up and being put in the appropriate modules and each of the modules getting a I can also see going the same route as contrib with Sounds like good tasks for follow up PRs. |
Because of #3949 (comment) I changed the "Fixed" to "Towards" in the PR description. I also added a comment to the issue about usage of |
Co-authored-by: Robert Pająk <[email protected]>
Towards #3946
Currently the SDK resources report the SDK version as the API version. If a project uses a different version of the SDK than the API this information will be incorrect. Add a version function to the SDK and use it.