Revert "Move metric No-Op to metric/noop (#3893)" #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:API
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3921 +/- ##
=======================================
- Coverage 81.8% 81.8% -0.1%
=======================================
Files 170 170
Lines 12915 12909 -6
=======================================
- Hits 10566 10561 -5
+ Misses 2130 2129 -1
Partials 219 219
|
MadVikingGod
approved these changes
Mar 22, 2023
Aneurysm9
approved these changes
Mar 22, 2023
|
Merging prior to the full working day as this was discussed via a video chat (see this) |
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Mar 27, 2023
…" (open-telemetry#3921)" This reverts commit 795ad97.
MrAlias
added a commit
that referenced
this pull request
Mar 29, 2023
* Revert "Revert "Move metric No-Op to metric/noop (#3893)" (#3921)" This reverts commit 795ad97. * Add PR number * Move example_test back to `otel/metric` * Update CHANGELOG.md Co-authored-by: Robert Pająk <[email protected]> * Remove redundant panic tests * Update noop pkg docs --------- Co-authored-by: Robert Pająk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3c75a44 while keeping the removal of
NewNoopMeter.With the possibility to use major version revisions to handle API evolution, including the No-Op does not provide the value we originally intended. If we decide at a later date to not go with major version revisions this can be added back in then.