Make TracerProvider not allow to register a SpanProcessor after shutdown #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash2k
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
ash2k
commented
Mar 8, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3845 +/- ##
=====================================
Coverage 81.7% 81.7%
=====================================
Files 170 170
Lines 12915 12915
=====================================
+ Hits 10562 10564 +2
+ Misses 2134 2132 -2
Partials 219 219
|
pellared
approved these changes
Mar 9, 2023
hanyuancheung
approved these changes
Mar 10, 2023
pellared
requested changes
Mar 22, 2023
ash2k
force-pushed
the
set-shutdown-flag
branch
from
41c7941 to
5b5740e
Compare
ash2k
changed the title
ash2k
changed the title
|
Can you also double check if it fixes #3890? |
|
@pellared I don't think it does. I don't want to couple two fixes in a single PR to be honest. Especially with reviews being so slow, I'd rather open a separate PR. |
dmathieu
approved these changes
Mar 22, 2023
ash2k
force-pushed
the
set-shutdown-flag
branch
from
5b5740e to
353a79f
Compare
ash2k
force-pushed
the
set-shutdown-flag
branch
from
353a79f to
259301d
Compare
pellared
approved these changes
Mar 22, 2023
Aneurysm9
approved these changes
Mar 22, 2023
MrAlias
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
isShutdownis not set whenspanProcessorsis empty. It must always be set because it influences how other methods behave e.g.RegisterSpanProcessor().