-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Note about dropping go 1.18 #3771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
pellared,
hanyuancheung and
dmathieu
as code owners
February 24, 2023 14:40
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3771 +/- ##
=====================================
Coverage 81.7% 81.7%
=====================================
Files 167 167
Lines 12453 12459 +6
=====================================
+ Hits 10175 10181 +6
Misses 2063 2063
Partials 215 215
|
dmathieu
approved these changes
Feb 24, 2023
pellared
reviewed
Feb 27, 2023
MrAlias
reviewed
Feb 27, 2023
Aneurysm9
approved these changes
Feb 27, 2023
MrAlias
reviewed
Feb 27, 2023
Co-authored-by: Robert Pająk <[email protected]>
MrAlias
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change to note the dropping support of 1.18