-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run website formatter over website_docs #3762
Run website formatter over website_docs #3762
Conversation
Link checking (for both internal and external links) is passing when I run this PR through the website's link checker. I'm not quite sure why the "check-links" action is failing. |
a99d9a9
to
3de273d
Compare
Link checking is passing now. I added ignore rules to the Lychee ignore file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be planned. But how about running the formatter in an action and checking that the working directory is still clean, to ensure we don't introduce formatting issues in future changes?
@@ -2,3 +2,5 @@ http://localhost | |||
http://jaeger-collector | |||
https://github.com/open-telemetry/opentelemetry-go/milestone/ | |||
https://github.com/open-telemetry/opentelemetry-go/projects | |||
file:///home/runner/work/opentelemetry-go/opentelemetry-go/libraries | |||
file:///home/runner/work/opentelemetry-go/opentelemetry-go/manual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems specific to your local setup. Would there be a way for you to setup a global lycheeignore file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this isn't local to my setup. The build of this PR was failing earlier because of check-links errors, https://github.com/open-telemetry/opentelemetry-go/actions/runs/4238014997/jobs/7364617339:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. I'd suggest adding a comment specifying this path is for GH Actions. But it seems lycheeignore doesn't allow comments 😞
Thanks for the review @dmathieu.
The plan is to migrate the Go OTel Go is the last of the language SIGs to have their core non-API docs migrated. The website has the CI checks in place already so I don't think that it's worth setting up an action in this repo. The OTel website team is eager to the Go docs migrated, so if there's anything we can do to help make that happen, let us know! |
Correction: the CI formatting checks are in place for most of the website docs, but pending for the Go docs; they'll be introduced for Go via: |
FWIW @dmathieu we did discuss moving the docs in a Go SIG a little while back -- the main thing is we (well, realistically me) need to address some concerns in the Getting Started side of things and work out a good way to make sure that the sample apps in this repo and docs both reflect the right way to use the SDK. |
I'd vote to migrate the docs to the website, without waiting for the said updates :). |
In the meantime, is this good to go? |
3de273d
to
9950ead
Compare
Thanks for merging! |
@dmathieu - "CI formatting checks for Go docs" PR is ready for review, FYI: |
Enable Prettier check over instrumentation/go & update go opentelemetry.io#2380
website_docs/*.md
relref
link(s) by standard markdown link(s)/cc @cartermp @svrnm