Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated instrument packages #3631

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 30, 2023

No description provided.

@MrAlias MrAlias added pkg:API Related to an API package area:metrics Part of OpenTelemetry Metrics labels Jan 30, 2023
@MrAlias MrAlias marked this pull request as ready for review January 30, 2023 16:34
@MrAlias MrAlias added this to the Metric v0.36.0 milestone Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #3631 (0979203) into main (cfed995) will decrease coverage by 0.1%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3631     +/-   ##
=======================================
- Coverage   79.7%   79.7%   -0.1%     
=======================================
  Files        171     171             
  Lines      12673   12673             
=======================================
- Hits       10103   10101      -2     
- Misses      2357    2359      +2     
  Partials     213     213             
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 80.2% <0.0%> (-1.8%) ⬇️
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️

@MrAlias MrAlias merged commit aa51224 into open-telemetry:main Jan 31, 2023
@MrAlias MrAlias deleted the rm-inst-pkgs branch January 31, 2023 16:12
@lzap
Copy link

lzap commented Feb 17, 2023

Hello, this breaks our project, how do I deal with this? Any advice? Should I pin a particular version?

#3740

Solved by pinning for now, not sure what is causing this (other dependency?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:API Related to an API package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants