Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale comments from metric global #3603

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 19, 2023

The Observe is not used to record measurements following #3584.

The Observe is not used to record measurements following open-telemetry#3584.
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 19, 2023
@MrAlias MrAlias added this to the Metric v0.35.0 milestone Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #3603 (5a379bb) into main (69b18e6) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3603   +/-   ##
=====================================
  Coverage   79.0%   79.0%           
=====================================
  Files        170     170           
  Lines      12587   12587           
=====================================
+ Hits        9948    9952    +4     
+ Misses      2426    2422    -4     
  Partials     213     213           
Impacted Files Coverage Δ
metric/internal/global/meter.go 93.8% <ø> (ø)
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️
sdk/trace/batch_span_processor.go 81.1% <0.0%> (+0.8%) ⬆️

@MrAlias MrAlias added the documentation Provides helpful information label Jan 19, 2023
@MrAlias
Copy link
Contributor Author

MrAlias commented Jan 19, 2023

Given this is a minor doc cleanup in an unexported package, I'm merging prior to the 1 full working day of being open.

@MrAlias MrAlias merged commit b1a8002 into open-telemetry:main Jan 19, 2023
@MrAlias MrAlias deleted the stale-comment-cleanup branch January 19, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants