Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TracerProvider shutdown release resources #3551

Conversation

fatsheep9146
Copy link
Contributor

fix #3534

Signed-off-by: Ziqi Zhao [email protected]

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #3551 (0b0e823) into main (ad4d54e) will decrease coverage by 0.0%.
The diff coverage is 45.4%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3551     +/-   ##
=======================================
- Coverage   78.1%   78.0%   -0.1%     
=======================================
  Files        164     164             
  Lines      11815   11826     +11     
=======================================
+ Hits        9228    9233      +5     
- Misses      2391    2395      +4     
- Partials     196     198      +2     
Impacted Files Coverage Δ
sdk/trace/provider.go 87.2% <45.4%> (-2.1%) ⬇️
sdk/trace/batch_span_processor.go 80.2% <0.0%> (-0.9%) ⬇️
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️

Signed-off-by: Ziqi Zhao <[email protected]>
Copy link
Member

@hanyuancheung hanyuancheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CHANGELOG.md Outdated Show resolved Hide resolved
@fatsheep9146
Copy link
Contributor Author

@MrAlias could you help review this pr?

CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit c82dbdd into open-telemetry:main Jan 3, 2023
@MrAlias MrAlias added this to the Release v1.12.0 milestone Jan 27, 2023
@MrAlias MrAlias mentioned this pull request Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document TracerProvider Shutdown as releasing resources
4 participants