-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TracerProvider shutdown release resources #3551
Merged
MrAlias
merged 8 commits into
open-telemetry:main
from
fatsheep9146:traceprovider-shutdown-release-resource
Jan 3, 2023
Merged
TracerProvider shutdown release resources #3551
MrAlias
merged 8 commits into
open-telemetry:main
from
fatsheep9146:traceprovider-shutdown-release-resource
Jan 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ziqi Zhao <[email protected]>
fatsheep9146
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
December 20, 2022 05:01
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3551 +/- ##
=======================================
- Coverage 78.1% 78.0% -0.1%
=======================================
Files 164 164
Lines 11815 11826 +11
=======================================
+ Hits 9228 9233 +5
- Misses 2391 2395 +4
- Partials 196 198 +2
|
Signed-off-by: Ziqi Zhao <[email protected]>
hanyuancheung
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
dashpole
reviewed
Dec 20, 2022
dashpole
reviewed
Dec 20, 2022
Co-authored-by: David Ashpole <[email protected]>
Signed-off-by: Ziqi Zhao <[email protected]>
dashpole
approved these changes
Dec 21, 2022
@MrAlias could you help review this pr? |
MrAlias
reviewed
Jan 3, 2023
MrAlias
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3534
Signed-off-by: Ziqi Zhao [email protected]