Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: Implement MetricProducer by making the SDK a Producer #3523

Closed
wants to merge 1 commit into from

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Dec 7, 2022

Issue: #3504

Implements open-telemetry/opentelemetry-specification#2951.

This is an example of how metric.Producer could be implemented such that the SDK itself is a "special" producer. I'm also going to prototype what it would look like to keep the interfaces separate.

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #3523 (b64a097) into main (4146bd1) will decrease coverage by 0.1%.
The diff coverage is 89.3%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3523     +/-   ##
=======================================
- Coverage   78.1%   78.0%   -0.2%     
=======================================
  Files        165     164      -1     
  Lines      11809   11742     -67     
=======================================
- Hits        9228    9160     -68     
- Misses      2385    2386      +1     
  Partials     196     196             
Impacted Files Coverage Δ
sdk/metric/manual_reader.go 80.4% <87.8%> (+1.7%) ⬆️
sdk/metric/periodic_reader.go 88.9% <90.0%> (-0.6%) ⬇️
sdk/metric/pipeline.go 95.1% <100.0%> (+1.4%) ⬆️
sdk/metric/reader.go 100.0% <100.0%> (ø)
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️
sdk/metric/view/view.go

@MrAlias
Copy link
Contributor

MrAlias commented Dec 8, 2022

Reviewers: looking for high-level feedback on interface design here.

@dashpole
Copy link
Contributor Author

dashpole commented Dec 8, 2022

Closing this for now based on feedback from the sig meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants