Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WithAggregationSelector to prometheus #3341

Merged
merged 4 commits into from
Oct 18, 2022

Conversation

MadVikingGod
Copy link
Contributor

Fixes: #3196

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #3341 (3c36dba) into main (8b25cb2) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3341   +/-   ##
=====================================
  Coverage   77.8%   77.8%           
=====================================
  Files        164     164           
  Lines      11267   11278   +11     
=====================================
+ Hits        8773    8782    +9     
- Misses      2297    2299    +2     
  Partials     197     197           
Impacted Files Coverage Δ
exporters/prometheus/config.go 100.0% <100.0%> (ø)
exporters/prometheus/exporter.go 81.4% <100.0%> (ø)
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️

CHANGELOG.md Outdated Show resolved Hide resolved
exporters/prometheus/confg_test.go Outdated Show resolved Hide resolved
exporters/prometheus/config.go Show resolved Hide resolved
@MrAlias MrAlias added this to the Metric v0.33.0 milestone Oct 17, 2022
@MrAlias MrAlias merged commit 9915342 into open-telemetry:main Oct 18, 2022
@MrAlias MrAlias mentioned this pull request Oct 19, 2022
@MadVikingGod MadVikingGod deleted the mvg/prom-agg-selector branch February 21, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

No way to configure default histogram buckets with prometheus exporter
4 participants