Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sdktrace.TraceProvider Shutdown/ForceFlush when no processor register #3268

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

bogdandrutu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #3268 (c0cc54f) into main (4a3adaa) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3268   +/-   ##
=====================================
  Coverage   77.6%   77.7%           
=====================================
  Files        161     162    +1     
  Lines      11260   11255    -5     
=====================================
+ Hits        8741    8747    +6     
+ Misses      2319    2311    -8     
+ Partials     200     197    -3     
Impacted Files Coverage Δ
sdk/trace/provider.go 89.2% <100.0%> (+3.5%) ⬆️
sdk/trace/span.go 88.3% <100.0%> (ø)
sdk/trace/span_processor.go 100.0% <100.0%> (ø)
sdk/trace/tracer.go 100.0% <100.0%> (ø)
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️

@@ -51,7 +51,7 @@ func (tr *tracer) Start(ctx context.Context, name string, options ...trace.SpanS

s := tr.newSpan(ctx, name, &config)
if rw, ok := s.(ReadWriteSpan); ok && s.IsRecording() {
sps, _ := tr.provider.spanProcessors.Load().(spanProcessorStates)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but this may also have caused a panic (someone else if really interested can investigate).

sdk/trace/provider.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias added this to the Release v1.12.0 milestone Oct 12, 2022
@MrAlias MrAlias merged commit e4bdfe7 into open-telemetry:main Oct 12, 2022
@bogdandrutu bogdandrutu deleted the fixprovider branch October 12, 2022 21:52
@MrAlias MrAlias mentioned this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants