Use default view if instrument does not match any pipeline view #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
bug
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3237 +/- ##
=====================================
Coverage 77.3% 77.3%
=====================================
Files 159 159
Lines 11182 11192 +10
=====================================
+ Hits 8647 8656 +9
Misses 2337 2337
- Partials 198 199 +1
|
MrAlias
force-pushed
the
default-view
branch
from
3a0d895 to
3ab3eed
Compare
MrAlias
force-pushed
the
default-view
branch
from
7b49c9e to
aca054b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
paivagustavo
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
👀 just passing by
We should be able to remove this as well: https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/metric/config.go#L129-L131
MadVikingGod
approved these changes
Sep 29, 2022
This reverts commit b56efb0.
|
@paivagustavo I reverted b56efb0. It indeed corrected incorrect behavior, but our tests expected this behavior. The fix for the issue is included in #3251. I will make sure to handle the merge conflict by including the fix in the default view match based on whichever one is merged first. |
Aneurysm9
approved these changes
Oct 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3224