Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused internal member, shows that Config.DefaultHistogramBoundaries is unused #2765

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Remove unused internal member, shows that Config.DefaultHistogramBoundaries is unused #2765

merged 2 commits into from
Apr 7, 2022

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

jmacd
jmacd approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. FWIW this metrics SDK branch lets views control the histogram boundaries and readers control the default histogram boundaries for int64 and float64 independently.

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #2765 (88cc385) into main (4bbf8d6) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2765   +/-   ##
=====================================
  Coverage   76.7%   76.8%           
=====================================
  Files        181     181           
  Lines      12189   12188    -1     
=====================================
+ Hits        9361    9366    +5     
+ Misses      2603    2597    -6     
  Partials     225     225
Impacted Files Coverage Δ
exporters/prometheus/prometheus.go 65.0% <100.0%> (-0.3%) ⬇️
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️
sdk/trace/batch_span_processor.go 82.1% <0.0%> (+1.8%) ⬆️

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 7, 2022
@MrAlias MrAlias merged commit 376c23c into open-telemetry:main Apr 7, 2022
@bogdandrutu bogdandrutu deleted the rmdeadcode branch April 11, 2022 16:10
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@jmacd jmacd jmacd approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.
5 participants
@bogdandrutu @jmacd @MrAlias @pellared @hanyuancheung