When using WithNewRoot, don't use the parent context for sampling #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
requested review from
Aneurysm9,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2032 +/- ##
=====================================
Coverage 72.7% 72.7%
=====================================
Files 164 164
Lines 8079 8081 +2
=====================================
+ Hits 5876 5878 +2
Misses 1974 1974
Partials 229 229
|
dashpole
force-pushed
the
newroot_nosample
branch
from
87e148c
to
e5381e6
Compare
Aneurysm9
approved these changes
Jun 25, 2021
XSAM
approved these changes
Jun 25, 2021
MrAlias
approved these changes
Jun 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2031