-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add span.TracerProvider() #2009
Merged
Aneurysm9
merged 4 commits into
open-telemetry:main
from
Aneurysm9:feat/spanTracerProvider
Jun 17, 2021
Merged
Add span.TracerProvider() #2009
Aneurysm9
merged 4 commits into
open-telemetry:main
from
Aneurysm9:feat/spanTracerProvider
Jun 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anthony J Mirabella <[email protected]>
Aneurysm9
requested review from
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo and
XSAM
as code owners
June 17, 2021 00:38
Signed-off-by: Anthony J Mirabella <[email protected]>
Aneurysm9
force-pushed
the
feat/spanTracerProvider
branch
from
June 17, 2021 00:39
4c3d3c2
to
4f19882
Compare
Codecov Report
@@ Coverage Diff @@
## main #2009 +/- ##
=====================================
Coverage 73.0% 73.0%
=====================================
Files 171 171
Lines 8675 8687 +12
=====================================
+ Hits 6338 6348 +10
- Misses 2068 2070 +2
Partials 269 269
|
Aneurysm9
added
area:trace
Part of OpenTelemetry tracing
enhancement
New feature or request
pkg:API
Related to an API package
pkg:SDK
Related to an SDK package
priority:p1
labels
Jun 17, 2021
dashpole
approved these changes
Jun 17, 2021
MrAlias
approved these changes
Jun 17, 2021
…provider Signed-off-by: Anthony J Mirabella <[email protected]>
MrAlias
approved these changes
Jun 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:trace
Part of OpenTelemetry tracing
enhancement
New feature or request
pkg:API
Related to an API package
pkg:SDK
Related to an SDK package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
TracerProvider()
method to thetrace.Span
interface. This method allows instrumentation authors to obtain aTracerProvider
without pre-configuration by extracting aSpan
from aContext
and utilizing theTracerProvider
that was used to construct the extractedSpan
.