Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split stdout exporter into stdouttrace and stdoutmetric #2005

Merged
merged 7 commits into from
Jun 16, 2021

Conversation

Aneurysm9
Copy link
Member

Signed-off-by: Anthony J Mirabella [email protected]

@Aneurysm9 Aneurysm9 force-pushed the fix/stdout_exporter branch from a5507c4 to d8faeb9 Compare June 14, 2021 22:09
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #2005 (38562cb) into main (80ca2b1) will increase coverage by 0.0%.
The diff coverage is 77.2%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2005   +/-   ##
=====================================
  Coverage   72.8%   72.8%           
=====================================
  Files        169     171    +2     
  Lines       8667    8675    +8     
=====================================
+ Hits        6311    6321   +10     
+ Misses      2084    2082    -2     
  Partials     272     272           
Impacted Files Coverage Δ
exporters/stdout/stdoutmetric/exporter.go 66.6% <ø> (ø)
exporters/stdout/stdoutmetric/metric.go 78.5% <ø> (ø)
exporters/stdout/stdouttrace/trace.go 69.5% <0.0%> (ø)
exporters/stdout/stdouttrace/exporter.go 66.6% <66.6%> (ø)
exporters/stdout/stdouttrace/config.go 81.8% <81.8%> (ø)
exporters/stdout/stdoutmetric/config.go 85.7% <100.0%> (ø)

exporters/stdout/stdoutmetric/config.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutmetric/doc.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutmetric/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutmetric/metric.go Outdated Show resolved Hide resolved
exporters/stdout/stdouttrace/config.go Outdated Show resolved Hide resolved
exporters/stdout/stdouttrace/config.go Outdated Show resolved Hide resolved
exporters/stdout/stdouttrace/doc.go Show resolved Hide resolved
exporters/stdout/stdouttrace/exporter.go Outdated Show resolved Hide resolved
exporters/stdout/stdouttrace/trace.go Outdated Show resolved Hide resolved
Copy link
Contributor

@MadVikingGod MadVikingGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how deep the Without* options run. It would be nice to have them out but I would be ok with leaving them, as this is intended to be a tool for us to develop with.

Thanks for putting this together.

exporters/stdout/stdoutmetric/config.go Outdated Show resolved Hide resolved
exporters/stdout/stdoutmetric/doc.go Outdated Show resolved Hide resolved
exporters/stdout/stdouttrace/config.go Outdated Show resolved Hide resolved
@Aneurysm9 Aneurysm9 merged commit c30cd1d into open-telemetry:main Jun 16, 2021
@Aneurysm9 Aneurysm9 mentioned this pull request Jun 17, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants