Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests for trace package. #2004

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Add more tests for trace package. #2004

merged 2 commits into from
Jun 17, 2021

Conversation

euskadi31
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 14, 2021 •
edited
Loading

Codecov Report

Merging #2004 (da19d0e) into main (6d4a38f) will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2004     +/-   ##
=======================================
+ Coverage   72.8%   73.0%   +0.1%     
=======================================
  Files        171     171             
  Lines       8675    8675             
=======================================
+ Hits        6321    6338     +17     
+ Misses      2082    2068     -14     
+ Partials     272     269      -3
Impacted Files Coverage Δ
trace/trace.go 98.2% <0.0%> (+14.6%) ⬆️

XSAM
XSAM approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we skip this changelog? These changes do not affect our end-users.

@XSAM XSAM added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 15, 2021
@euskadi31 euskadi31 force-pushed the feature/more-tests branch from ae888ee to bf994cb Compare June 15, 2021 07:57
@euskadi31
Copy link
Contributor Author

@XSAM done :)

@euskadi31 euskadi31 requested review from XSAM and MadVikingGod June 15, 2021 07:59
MrAlias
MrAlias requested changes Jun 15, 2021
View reviewed changes
trace/trace_test.go Outdated Show resolved Hide resolved
trace/trace_test.go Outdated Show resolved Hide resolved
trace/trace_test.go Show resolved Hide resolved
trace/trace_test.go Outdated Show resolved Hide resolved
trace/trace_test.go Show resolved Hide resolved
trace/trace_test.go Outdated Show resolved Hide resolved
trace/trace_test.go Outdated Show resolved Hide resolved
trace/trace_test.go Outdated Show resolved Hide resolved
@euskadi31 euskadi31 force-pushed the feature/more-tests branch from da7239b to 550afb2 Compare June 16, 2021 07:32
@euskadi31 euskadi31 requested a review from MrAlias June 16, 2021 07:33
@euskadi31 euskadi31 force-pushed the feature/more-tests branch from 550afb2 to 9b583d0 Compare June 17, 2021 15:24
@MrAlias MrAlias merged commit d020e1a into open-telemetry:main Jun 17, 2021
@euskadi31 euskadi31 deleted the feature/more-tests branch June 17, 2021 15:59
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XSAM XSAM XSAM approved these changes

@MrAlias MrAlias MrAlias approved these changes

@dashpole dashpole dashpole approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@jmacd jmacd Awaiting requested review from jmacd

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.
6 participants
@euskadi31 @dashpole @MadVikingGod @MrAlias @XSAM @pellared