Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Status type to SDK #1874

Merged
merged 8 commits into from
May 3, 2021
Merged

Add Status type to SDK #1874

merged 8 commits into from
May 3, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented May 2, 2021

Instead of having two methods to return related information about the span status, use this new type to encapsulate the Span status similar to how the Event type encapsulates a Span event and the Link type encapsulates a span link.

Additionally, change the term status message to status description to match the language in the specification.

Part of the clean up included in #1873 for #1380.

Use this type to encapsulate the Span status similar to the Event type
encapsulating a Span event and the Link type a span link.
@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #1874 (4f28bd0) into main (f90d0d9) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1874   +/-   ##
=====================================
  Coverage   78.7%   78.7%           
=====================================
  Files        137     137           
  Lines       7343    7339    -4     
=====================================
- Hits        5784    5781    -3     
  Misses      1317    1317           
+ Partials     242     241    -1     
Impacted Files Coverage Δ
trace/trace.go 86.7% <ø> (ø)
exporters/otlp/internal/otlptest/data.go 87.7% <100.0%> (-0.3%) ⬇️
exporters/otlp/internal/transform/span.go 98.1% <100.0%> (ø)
exporters/trace/jaeger/jaeger.go 92.3% <100.0%> (-0.6%) ⬇️
exporters/trace/zipkin/model.go 99.1% <100.0%> (ø)
sdk/trace/span.go 93.9% <100.0%> (-0.1%) ⬇️
sdk/trace/batch_span_processor.go 87.1% <0.0%> (+1.5%) ⬆️

CHANGELOG.md Outdated Show resolved Hide resolved
exporters/trace/zipkin/model_test.go Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit b7d02db into open-telemetry:main May 3, 2021
@MrAlias MrAlias deleted the sdk-status branch May 3, 2021 19:01
@Aneurysm9 Aneurysm9 mentioned this pull request Jun 17, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants