-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Status type to SDK #1874
Merged
Merged
Add Status type to SDK #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this type to encapsulate the Span status similar to the Event type encapsulating a Span event and the Link type a span link.
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
paivagustavo and
XSAM
as code owners
May 2, 2021 21:10
Codecov Report
@@ Coverage Diff @@
## main #1874 +/- ##
=====================================
Coverage 78.7% 78.7%
=====================================
Files 137 137
Lines 7343 7339 -4
=====================================
- Hits 5784 5781 -3
Misses 1317 1317
+ Partials 242 241 -1
|
paivagustavo
approved these changes
May 3, 2021
Aneurysm9
suggested changes
May 3, 2021
Co-authored-by: Anthony Mirabella <[email protected]>
Aneurysm9
approved these changes
May 3, 2021
jmacd
approved these changes
May 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having two methods to return related information about the span status, use this new type to encapsulate the Span status similar to how the Event type encapsulates a Span event and the Link type encapsulates a span link.
Additionally, change the term status message to status description to match the language in the specification.
Part of the clean up included in #1873 for #1380.