Fix stdout TestStdoutTimestamp failure with sleep #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the test condition is valid by introducing minimal sleep durations before and after a timestamp is measured. Resolves open-telemetry#1571
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey and
XSAM
as code owners
Aneurysm9
approved these changes
Feb 23, 2021
punya
approved these changes
Feb 23, 2021
Codecov Report
@@ Coverage Diff @@
## main #1572 +/- ##
=====================================
Coverage 78.0% 78.0%
=====================================
Files 127 127
Lines 6597 6597
=====================================
Hits 5151 5151
- Misses 1201 1202 +1
+ Partials 245 244 -1
|
Merged
ldelossa
pushed a commit
to ldelossa/opentelemetry-go
that referenced
this pull request
Mar 5, 2021
* Fix stdout TestStdoutTimestamp failure with sleep Ensure the test condition is valid by introducing minimal sleep durations before and after a timestamp is measured. Resolves open-telemetry#1571 * Add changes to changelog Co-authored-by: Anthony Mirabella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the test condition is valid by introducing minimal sleep durations before and after a timestamp is measured.
Resolves #1571