Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stagger timestamps in exact aggregator tests. #1568

Closed
wants to merge 2 commits into from

Conversation

punya
Copy link
Member

@punya punya commented Feb 23, 2021

Fixes #1559.

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #1568 (8f36512) into main (b94cd4b) will decrease coverage by 0.2%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1568     +/-   ##
=======================================
- Coverage   78.2%   78.0%   -0.3%     
=======================================
  Files        127     127             
  Lines       6577    6600     +23     
=======================================
- Hits        5149    5148      -1     
- Misses      1183    1205     +22     
- Partials     245     247      +2     
Impacted Files Coverage Δ
sdk/metric/aggregator/exact/exact.go 84.6% <0.0%> (-9.9%) ⬇️
attribute/type_string.go 10.0% <0.0%> (-23.4%) ⬇️
metric/instrumentkind_string.go 10.0% <0.0%> (-23.4%) ⬇️
metric/number/kind_string.go 16.6% <0.0%> (-16.7%) ⬇️
sdk/export/metric/exportkind_string.go 0.0% <0.0%> (ø)

@punya punya closed this Feb 23, 2021
@punya punya deleted the break-ties branch February 23, 2021 03:25
@punya punya changed the title Break ties when merging time series Stagger timestamps in exact aggregator tests. Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests flaking in CI
1 participant