Remove resampling on span.SetName #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
requested review from
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
The spec makes it optional to attempt resampling when changing the name of a span and we're not sure whether it can be done in an appropriate manner, so it's best to not do it at all for now. We can try again later if we find a good way to do it.
Codecov Report
@@ Coverage Diff @@
## main #1545 +/- ##
=======================================
- Coverage 78.1% 78.0% -0.1%
=======================================
Files 127 127
Lines 6600 6582 -18
=======================================
- Hits 5156 5136 -20
- Misses 1200 1201 +1
- Partials 244 245 +1
|
punya
approved these changes
Feb 18, 2021
dashpole
approved these changes
Feb 18, 2021
MrAlias
approved these changes
Feb 18, 2021
Merged
ldelossa
pushed a commit
to ldelossa/opentelemetry-go
that referenced
this pull request
Mar 5, 2021
The spec makes it optional to attempt resampling when changing the name of a span and we're not sure whether it can be done in an appropriate manner, so it's best to not do it at all for now. We can try again later if we find a good way to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec makes it optional to attempt resampling when changing the name
of a span and we're not sure whether it can be done in an appropriate
manner, so it's best to not do it at all for now. We can try again
later if we find a good way to do it.
Resolves #224