-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenCensus metric exporter bridge #1444
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
January 8, 2021 22:13
dashpole
force-pushed
the
oc_metrics_bridge
branch
5 times, most recently
from
January 11, 2021 14:11
ad4ab62
to
721ccc1
Compare
Codecov Report
@@ Coverage Diff @@
## main #1444 +/- ##
=======================================
+ Coverage 77.3% 77.7% +0.3%
=======================================
Files 128 130 +2
Lines 6796 6924 +128
=======================================
+ Hits 5256 5382 +126
- Misses 1290 1292 +2
Partials 250 250
|
dashpole
force-pushed
the
oc_metrics_bridge
branch
5 times, most recently
from
January 11, 2021 21:06
f69a78f
to
11314d9
Compare
Aneurysm9
approved these changes
Jan 12, 2021
dashpole
force-pushed
the
oc_metrics_bridge
branch
from
January 12, 2021 16:01
96e5f0d
to
54f2798
Compare
dashpole
force-pushed
the
oc_metrics_bridge
branch
from
January 29, 2021 15:54
54f2798
to
18b4380
Compare
Friendly ping for reviews! |
dashpole
force-pushed
the
oc_metrics_bridge
branch
from
January 29, 2021 16:15
18b4380
to
8da00c1
Compare
sirianni
reviewed
Feb 2, 2021
dashpole
force-pushed
the
oc_metrics_bridge
branch
from
February 4, 2021 20:16
d8976da
to
5349fd6
Compare
dashpole
force-pushed
the
oc_metrics_bridge
branch
from
February 26, 2021 16:34
5349fd6
to
4d85c96
Compare
rebased again. @jmacd I think you said you wanted to take a look at this. |
dashpole
force-pushed
the
oc_metrics_bridge
branch
from
February 26, 2021 16:43
4d85c96
to
0924a02
Compare
dashpole
force-pushed
the
oc_metrics_bridge
branch
from
March 5, 2021 15:39
0924a02
to
2e58fd0
Compare
Co-authored-by: Eric Sirianni <[email protected]>
MrAlias
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93
This allows wrapping an OpenTelemetry exporter so that it can be used with OpenCensus. This is useful to facilitate migrations from OpenCensus to OpenTelemetry, as it would allow using a mix of OpenCensus and OpenTelemetry APIs in code (and libraries), while sending all telemetry to a single exporter.
Everything was straightforward to map, except the data points themselves. To do that, I ended up having to implement custom
Aggregation
s based on the data point type.I also need to do an audit of OpenCensus functionality that is "dropped" when using the bridge and document it. Thus far, I know it drops
Summary
data points, exemplars, and some types of metric descriptors. I might do that in a follow-up.