Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CorrelationContext to Baggage #1142

Merged
merged 4 commits into from
Sep 9, 2020
Merged

Rename CorrelationContext to Baggage #1142

merged 4 commits into from
Sep 9, 2020

Conversation

Aneurysm9
Copy link
Member

Fixes #1112

@codecov
Copy link

codecov bot commented Sep 9, 2020 •
edited
Loading

Codecov Report

Merging #1142 into master will decrease coverage by 0.3%.
The diff coverage is 79.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1142     +/-   ##
========================================
- Coverage    77.7%   77.3%   -0.4%     
========================================
  Files         135     135             
  Lines        7153    7107     -46     
========================================
- Hits         5558    5497     -61     
- Misses       1352    1363     +11     
- Partials      243     247      +4
Impacted Files Coverage Δ
api/baggage/context.go 23.3% <ø> (ø)
api/baggage/map.go 97.1% <ø> (ø)
bridge/opentracing/internal/mock.go 67.8% <33.3%> (ø)
bridge/opentracing/bridge.go 40.3% <81.8%> (ø)
api/baggage/baggage_propagator.go 84.3% <92.8%> (ø)
api/global/internal/state.go 83.6% <100.0%> (ø)
exporters/stdout/trace.go 43.7% <0.0%> (-25.5%) ⬇️
exporters/otlp/connection.go 78.7% <0.0%> (-17.1%) ⬇️
sdk/trace/provider.go 85.5% <0.0%> (-6.3%) ⬇️
exporters/trace/zipkin/zipkin.go 68.0% <0.0%> (-6.2%) ⬇️
... and 6 more

@Aneurysm9 Aneurysm9 merged commit 06689a0 into open-telemetry:master Sep 9, 2020
evantorrie pushed a commit to evantorrie/opentelemetry-go that referenced this pull request Sep 10, 2020
@Aneurysm9 @evantorrie
Rename CorrelationContext to Baggage (open-telemetry#1142)
fab7ae2 
* Rename 'correlation' to 'baggage'

* Rename CorrelationContext progator to Baggage

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@jmacd jmacd jmacd approved these changes

@evantorrie evantorrie Awaiting requested review from evantorrie

@lizthegrey lizthegrey Awaiting requested review from lizthegrey

@XSAM XSAM Awaiting requested review from XSAM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename CorrelationContext to Baggage
3 participants
@Aneurysm9 @jmacd @MrAlias