Add InstrumentationLibrary info to Zipkin/Jaeger exporters #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses spec issues open-telemetry/opentelemetry-specification#800 open-telemetry/opentelemetry-specification#801 and opentelemetry-go issues open-telemetry#1086 open-telemetry#1087
evantorrie
requested review from
Aneurysm9,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1119 +/- ##
======================================
Coverage 77.1% 77.2%
======================================
Files 133 133
Lines 7109 7113 +4
======================================
+ Hits 5488 5493 +5
+ Misses 1371 1369 -2
- Partials 250 251 +1
|
MrAlias
approved these changes
Sep 2, 2020
XSAM
approved these changes
Sep 3, 2020
evantorrie
added a commit
to evantorrie/opentelemetry-go
that referenced
this pull request
Sep 10, 2020
…metry#1119) * Add InstrumentationLibrary info to Zipkin/Jaeger exporters This addresses spec issues open-telemetry/opentelemetry-specification#800 open-telemetry/opentelemetry-specification#801 and opentelemetry-go issues open-telemetry#1086 open-telemetry#1087 * Reflect change in CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1086 #1087
This addresses spec issues
open-telemetry/opentelemetry-specification#800
open-telemetry/opentelemetry-specification#801