Remove google.golang.org/grpc/codes dependency from API by adding an equivalent codes package #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:API
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd and
lizthegrey
as code owners
jmacd
approved these changes
Aug 8, 2020
Aneurysm9
approved these changes
Aug 10, 2020
lizthegrey
approved these changes
Aug 10, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the API depend on
google.golang.org/grpcis undesirerable as it imposes large dependency requirements for any system wanting to use the OpenTelemetry API to instrument their code. This is contrary to the project goalsThe specification describes the canonical code to follow the standard gRPC codes. Building our own implementation of just the code portion of
google.golang.org/grpcis what is done here.This does not propagate the package all the way through the SDK and exporters. This is to minimize disruption for any existing exporters and given the same dependency concerns are not as stringent with the SDK (and the rest of the pipeline) this seems like the appropriate demarcation.
Part of #940
Resolves #973