Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: Add noCmp fields #5696

Closed
pellared opened this issue Aug 8, 2024 · 0 comments · Fixed by #5847
Closed

log: Add noCmp fields #5696

pellared opened this issue Aug 8, 2024 · 0 comments · Fixed by #5847
Assignees
@pellared
Labels
area:logs Part of OpenTelemetry logs enhancement New feature or request pkg:API Related to an API package
Milestone
untracked

Comments

@pellared
Copy link
Member

pellared commented Aug 8, 2024

This is not necessary, but may be good for maintaining backward compatiblity.
Should we do the same for Record, KeyValue, Value in go.opentelemetry.io/otel/log?

Originally posted by @pellared in #5693 (comment)
@pellared pellared added pkg:API Related to an API package area:logs Part of OpenTelemetry logs enhancement New feature or request labels Aug 8, 2024
@pellared pellared mentioned this issue Aug 8, 2024
Merged
@pellared pellared self-assigned this Sep 13, 2024
@pellared pellared mentioned this issue Sep 25, 2024
Merged
@pellared pellared moved this from Todo to In Progress in Go: Logs (GA) Sep 25, 2024
pellared added a commit that referenced this issue Sep 26, 2024
@pellared
log: Make Record not comparable (#5847)
f710cec 
Fixes #5696
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go: Logs (GA) Sep 26, 2024
@XSAM XSAM added this to the untracked milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
area:logs Part of OpenTelemetry logs enhancement New feature or request pkg:API Related to an API package
Projects
Go: Logs (GA)
Status: Done
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

log: Make Record not comparable pellared/opentelemetry-go
2 participants
@pellared @XSAM