You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#557 changed the CheckpointSet.ForEach() interface to
return an error from ForEach
allow the function passed to ForEach() to also return an error
The Prometheus Collect() makes use of CheckpointSet.ForEach() to iterate over the records. This code should be modified to reflect the change in error reporting behavior. For example, ErrNoData values could be returned from each of the export{Summary,Counter,LastValue} routines when appropriate, and any error returned from ForEach() should likely be reported via the error handler.
The text was updated successfully, but these errors were encountered:
evantorrie
changed the title
Prometheus Collect() should check return value from CheckpointSet.ForEach
Prometheus Collect() should check return value from CheckpointSet ForEach
Mar 17, 2020
This PR modifies prometheus.Collect to reflect the change introduced
by open-telemetry#557.
The `export{Counter,Histogram,LastValue,Summary}` methods now all return
an error instead of calling the error callback directly.
The callback is now only called on the returned error from `ForEach`.
fixesopen-telemetry#563
This PR modifies prometheus.Collect to reflect the change introduced
by #557.
The `export{Counter,Histogram,LastValue,Summary}` methods now all return
an error instead of calling the error callback directly.
The callback is now only called on the returned error from `ForEach`.
fixes#563
Co-authored-by: Rahul Patel <[email protected]>
#557 changed the
CheckpointSet.ForEach()
interface toForEach
ForEach()
to also return an errorThe Prometheus
Collect()
makes use ofCheckpointSet.ForEach()
to iterate over the records. This code should be modified to reflect the change in error reporting behavior. For example,ErrNoData
values could be returned from each of theexport{Summary,Counter,LastValue}
routines when appropriate, and any error returned fromForEach()
should likely be reported via the error handler.The text was updated successfully, but these errors were encountered: