Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the stubbed sync instruments #2814

Closed
MrAlias opened this issue Apr 19, 2022 · 2 comments · Fixed by #3124
Closed

Implement the stubbed sync instruments #2814

MrAlias opened this issue Apr 19, 2022 · 2 comments · Fixed by #3124
Assignees
@MadVikingGod
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Milestone
Metric SDK: Alpha

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Apr 19, 2022 •
edited
Loading

Blocked by #2800
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Apr 19, 2022
@MrAlias MrAlias added this to the Metric SDK: Alpha milestone Apr 19, 2022
@MrAlias MrAlias moved this from Blocked to Todo in OpenTelemetry Go: Metric SDK (Alpha) May 2, 2022
@MadVikingGod MadVikingGod mentioned this issue Jul 12, 2022
Closed
@MrAlias MrAlias mentioned this issue Jul 27, 2022
Closed
4 tasks
@MrAlias
Copy link
Contributor Author

MrAlias commented Jul 27, 2022

The Counter instrument needs to validate its input is zero or greater. The sum Aggregator does not do this.

@MadVikingGod MadVikingGod mentioned this issue Aug 29, 2022
Merged
@MrAlias MrAlias moved this from Todo to In Progress in OpenTelemetry Go: Metric SDK (Alpha) Aug 29, 2022
@MrAlias MrAlias linked a pull request Sep 1, 2022 that will close this issue
Add Synchronous instruments #3124
Merged
@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 1, 2022

Closed by #2814

@MrAlias MrAlias closed this as completed Sep 1, 2022
Repository owner moved this from In Progress to Done in OpenTelemetry Go: Metric SDK (Alpha) Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MadVikingGod MadVikingGod

Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
OpenTelemetry Go: Metric SDK (Alpha)
Status: Done
Milestone
Metric SDK: Alpha
Development

Successfully merging a pull request may close this issue.

Add Synchronous instruments MadVikingGod/opentelemetry-go
2 participants
@MadVikingGod @MrAlias