-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve test coverage, and don't send empty batches in OC bridge (#3263)
* improve test coverage, and don't send empty batches in OC bridge * Update bridge/opencensus/metric_test.go Co-authored-by: Tyler Yahn <[email protected]> * remove 1.18 rule Co-authored-by: Tyler Yahn <[email protected]>
- Loading branch information
Showing
7 changed files
with
185 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| // Copyright The OpenTelemetry Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package opencensus // import "go.opentelemetry.io/otel/bridge/opencensus" | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
| ocmetricdata "go.opencensus.io/metric/metricdata" | ||
| ocresource "go.opencensus.io/resource" | ||
|
|
||
| "go.opentelemetry.io/otel/attribute" | ||
| "go.opentelemetry.io/otel/sdk/instrumentation" | ||
| "go.opentelemetry.io/otel/sdk/metric" | ||
| "go.opentelemetry.io/otel/sdk/metric/metricdata" | ||
| "go.opentelemetry.io/otel/sdk/metric/metricdata/metricdatatest" | ||
| "go.opentelemetry.io/otel/sdk/resource" | ||
| ) | ||
|
|
||
| func TestPushMetricsExporter(t *testing.T) { | ||
| now := time.Now() | ||
| for _, tc := range []struct { | ||
| desc string | ||
| input []*ocmetricdata.Metric | ||
| inputResource *resource.Resource | ||
| exportErr error | ||
| expected *metricdata.ResourceMetrics | ||
| expectErr bool | ||
| }{ | ||
| { | ||
| desc: "empty batch isn't sent", | ||
| }, | ||
| { | ||
| desc: "export error", | ||
| exportErr: fmt.Errorf("failed to export"), | ||
| input: []*ocmetricdata.Metric{ | ||
| { | ||
| Resource: &ocresource.Resource{ | ||
| Labels: map[string]string{ | ||
| "R1": "V1", | ||
| "R2": "V2", | ||
| }, | ||
| }, | ||
| TimeSeries: []*ocmetricdata.TimeSeries{ | ||
| { | ||
| StartTime: now, | ||
| Points: []ocmetricdata.Point{ | ||
| {Value: int64(123), Time: now}, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| expectErr: true, | ||
| }, | ||
| { | ||
| desc: "success", | ||
| input: []*ocmetricdata.Metric{ | ||
| { | ||
| Resource: &ocresource.Resource{ | ||
| Labels: map[string]string{ | ||
| "R1": "V1", | ||
| "R2": "V2", | ||
| }, | ||
| }, | ||
| TimeSeries: []*ocmetricdata.TimeSeries{ | ||
| { | ||
| StartTime: now, | ||
| Points: []ocmetricdata.Point{ | ||
| {Value: int64(123), Time: now}, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| inputResource: resource.NewSchemaless( | ||
| attribute.String("R1", "V1"), | ||
| attribute.String("R2", "V2"), | ||
| ), | ||
| expected: &metricdata.ResourceMetrics{ | ||
| Resource: resource.NewSchemaless( | ||
| attribute.String("R1", "V1"), | ||
| attribute.String("R2", "V2"), | ||
| ), | ||
| ScopeMetrics: []metricdata.ScopeMetrics{ | ||
| { | ||
| Scope: instrumentation.Scope{ | ||
| Name: scopeName, | ||
| }, | ||
| Metrics: []metricdata.Metrics{ | ||
| { | ||
| Name: "", | ||
| Description: "", | ||
| Unit: "", | ||
| Data: metricdata.Gauge[int64]{ | ||
| DataPoints: []metricdata.DataPoint[int64]{ | ||
| { | ||
| Attributes: attribute.NewSet(), | ||
| StartTime: now, | ||
| Time: now, | ||
| Value: 123, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| } { | ||
| t.Run(tc.desc, func(t *testing.T) { | ||
| fake := &fakeExporter{err: tc.exportErr} | ||
| exporter := NewMetricExporter(fake, tc.inputResource) | ||
| err := exporter.ExportMetrics(context.Background(), tc.input) | ||
| if tc.expectErr { | ||
| require.Error(t, err) | ||
| } else { | ||
| require.NoError(t, err) | ||
| } | ||
| if tc.expected != nil { | ||
| require.NotNil(t, fake.data) | ||
| metricdatatest.AssertEqual(t, *tc.expected, *fake.data) | ||
| } else { | ||
| require.Nil(t, fake.data) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| type fakeExporter struct { | ||
| metric.Exporter | ||
| data *metricdata.ResourceMetrics | ||
| err error | ||
| } | ||
|
|
||
| func (f *fakeExporter) Export(ctx context.Context, data metricdata.ResourceMetrics) error { | ||
| if f.err == nil { | ||
| f.data = &data | ||
| } | ||
| return f.err | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters