fix code style

open-telemetry · Nov 16, 2023 · 960afe9 · 960afe9
1 parent 88c89b1
commit 960afe9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 ## [Unreleased]
 
+### Changed
+
+- Improve `go.opentelemetry.io/otel/propagation.TraceContext` 's performance (#4721)
+
 ### Removed
 
 - Remove the deprecated `go.opentelemetry.io/otel/bridge/opencensus.NewTracer`. (#4706)

diff --git a/propagation/trace_context.go b/propagation/trace_context.go
@@ -62,7 +62,7 @@ func (tc TraceContext) Inject(ctx context.Context, carrier TextMapCarrier) {
 
 	var sb strings.Builder
 	sb.Grow(2 + 32 + 16 + 2 + 3)
-	sb.WriteString(versionPart)
+	_, _ = sb.WriteString(versionPart)
 	traceID := sc.TraceID()
 	spanID := sc.SpanID()
 	flagByte := [1]byte{byte(flags)}
@@ -72,15 +72,15 @@ func (tc TraceContext) Inject(ctx context.Context, carrier TextMapCarrier) {
 
 func writeTraceParent(sb *strings.Builder, srcs ...[]byte) {
 	for _, src := range srcs {
-		sb.WriteByte(parentDelimiter[0])
+		_, _ = sb.WriteByte(parentDelimiter[0])
 		writeHex(sb, src)
 	}
 }
 
 func writeHex(sb *strings.Builder, src []byte) {
 	var dst [32]byte
 	n := hex.Encode(dst[:], src)
-	sb.Write(dst[:n])
+	_, _ = sb.Write(dst[:n])
 }
 
 // Extract reads tracecontext from the carrier into a returned Context.
@@ -146,7 +146,7 @@ func (tc TraceContext) extract(carrier TextMapCarrier) trace.SpanContext {
 	return sc
 }
 
-// upperHex detect hex is upper case
+// upperHex detect hex is upper case.
 func upperHex(v string) bool {
 	for _, c := range v {
 		if c >= 'A' && c <= 'F' {