Add tests for nil *Resource

open-telemetry · Sep 8, 2021 · 45f7dc6 · 45f7dc6
1 parent df2bdbb
commit 45f7dc6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/sdk/resource/resource.go b/sdk/resource/resource.go
@@ -132,6 +132,9 @@ func (r *Resource) Attributes() []attribute.KeyValue {
 }
 
 func (r *Resource) SchemaURL() string {
+	if r == nil {
+		return ""
+	}
 	return r.schemaURL
 }
 

diff --git a/sdk/resource/resource_test.go b/sdk/resource/resource_test.go
@@ -205,6 +205,17 @@ func TestMerge(t *testing.T) {
 	}
 }
 
+func TestEmpty(t *testing.T) {
+	var res *resource.Resource
+	require.Equal(t, "", res.SchemaURL())
+	require.Equal(t, "", res.String())
+	require.Equal(t, []attribute.KeyValue(nil), res.Attributes())
+
+	it := res.Iter()
+	require.Equal(t, 0, it.Len())
+	require.True(t, res.Equal(res))
+}
+
 func TestDefault(t *testing.T) {
 	res := resource.Default()
 	require.False(t, res.Equal(resource.Empty()))