Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make generate target #1237

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Conversation

RonFed
Copy link
Contributor

@RonFed RonFed commented Nov 2, 2024

The PROBE_GEN_OBJ targets are relevant when no object files are present (this is the case in CI, or in a fresh clone). However, when a .c files is being edited these targets won't cause re-generation (since the object files didn't change).
The PROBE_GEN_GO targets are relevant when the source code is being edited - these targets are included in the .d files with dependencies on the relevant source code files.

@RonFed RonFed marked this pull request as ready for review November 2, 2024 10:33
@RonFed RonFed requested a review from a team as a code owner November 2, 2024 10:33
@MrAlias MrAlias merged commit cb02997 into open-telemetry:main Nov 2, 2024
26 checks passed
@MrAlias MrAlias added this to the v0.17.0-alpha milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants