Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up Makefile test target #1216

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Clean-up Makefile test target #1216

merged 2 commits into from
Oct 24, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 24, 2024 •
edited
Loading

  • Correct test_ebpf to test-epbf to match existing make target
  • Remove go-mod-tidy from precommit as it is already a dependency of the other targets run
  • Add test target to precommit so it is run by default
  • Do not include verbose output in default test target
  • Unify test_ebpf target into test target as they are functionally identical
  • Add a test-verbose target to run tests with verbose output

@MrAlias MrAlias changed the title Update Makefile test target Clean-up Makefile test target Oct 24, 2024
@MrAlias MrAlias marked this pull request as ready for review October 24, 2024 18:52
@MrAlias MrAlias requested a review from a team as a code owner October 24, 2024 18:52
@MrAlias MrAlias merged commit 21f4f30 into open-telemetry:main Oct 24, 2024
26 checks passed
@MrAlias MrAlias deleted the make-test branch October 24, 2024 21:22
@MrAlias MrAlias added this to the v0.17.0-alpha milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonFed RonFed RonFed approved these changes

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
v0.17.0-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@MrAlias @RonFed