Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build-context from make fixtures #1198

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Oct 15, 2024

This flag was added in #1108 and I am not sure if that was intentional or not. Running it as it is, I get the following error:

make[1]: Leaving directory '/usr/local/google/home/mikedame/go/src/github.com/open-telemetry/opentelemetry-go-instrumentation'                    
if [ -f ./internal/test/e2e/grpc/build.sh ]; then \
	./internal/test/e2e/grpc/build.sh; \
else \
	cd internal/test/e2e/grpc && docker build --build-context ../../../../ -t sample-app . ;\
fi
unknown flag: --build-context
See 'docker build --help'.
make: *** [Makefile:167: fixtures/grpc] Error 125

Changing it to docker buildx build showed that it's actually supposed to be a key=value pair, so it doesn't seem to be used anyway:

ERROR: invalid context value: ../../../../, expected key=value
make: *** [Makefile:167: fixtures/grpc] Error 1

I don't think this was caught because our e2es don't actually call make fixtures, instead they re-build essentially the same steps without the need for docker

@damemi damemi requested a review from a team as a code owner October 15, 2024 15:36
@damemi
Copy link
Contributor Author

damemi commented Oct 15, 2024

cc @MrAlias please correct me if I'm wrong and this has a purpose I'm missing

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this was a mistake to have been merged. It was left over from other testing.

@MrAlias MrAlias merged commit 1a0acee into open-telemetry:main Oct 15, 2024
26 of 27 checks passed
@MrAlias MrAlias added this to the v0.16.0-alpha milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants