Remove build-context from make fixtures #1198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag was added in #1108 and I am not sure if that was intentional or not. Running it as it is, I get the following error:
Changing it to
docker buildx build
showed that it's actually supposed to be a key=value pair, so it doesn't seem to be used anyway:I don't think this was caught because our e2es don't actually call
make fixtures
, instead they re-build essentially the same steps without the need for docker