Instrument gRPC status code for client spans #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
reviewed
Aug 27, 2024
internal/pkg/instrumentation/bpf/google.golang.org/grpc/client/bpf/probe.bpf.c
Outdated
Show resolved
Hide resolved
damemi
commented
Aug 27, 2024
internal/pkg/instrumentation/bpf/google.golang.org/grpc/client/bpf/probe.bpf.c
Outdated
Show resolved
Hide resolved
MrAlias
reviewed
Aug 28, 2024
internal/pkg/instrumentation/bpf/google.golang.org/grpc/client/bpf/probe.bpf.c
Show resolved
Hide resolved
MrAlias
reviewed
Aug 28, 2024
internal/pkg/instrumentation/bpf/google.golang.org/grpc/client/probe.go
Outdated
Show resolved
Hide resolved
RonFed
reviewed
Aug 29, 2024
internal/pkg/instrumentation/bpf/google.golang.org/grpc/client/bpf/probe.bpf.c
Outdated
Show resolved
Hide resolved
damemi
changed the title
|
Updated the PR description and changelog to state that this is just for client spans. Looks like server spans will be a pretty different approach (reading handleStream) so I'll do a separate PR for that |
MrAlias
approved these changes
Aug 29, 2024
RonFed
reviewed
Aug 30, 2024
internal/pkg/instrumentation/bpf/google.golang.org/grpc/client/bpf/probe.bpf.c
Show resolved
Hide resolved
MrAlias
pushed a commit
to MrAlias/opentelemetry-go-instrumentation
that referenced
this pull request
Sep 18, 2024
* Add gRPC Status object to offsets * Add ClientConn_Invoke_Returns ebpf probe * Add status code to span event * make docker-generate * Set grpc.status.code attribute * Generate status code fixture * Add changelog entry * Generate error span in grpc test * Switch to int32 and change offset logic * Check argument 2 and use bpf_probe_read_user * Add error struct to pointer chain * Update verify.bats * lint * Fix span status * Skip error checks if resp==nil * Use u32 * Update changelog * Add call to stop_tracking_span * Make docker-offsets * Update changelog for new offsets * make fixture-grpc * Update bats test
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #172