Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase BSP timeout for a more consistent batch size in e2e tests #1029

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Increase BSP timeout for a more consistent batch size in e2e tests #1029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/e2e/k8s/sample-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ spec:
value: "tracecontext,baggage"
- name: OTEL_GO_AUTO_INCLUDE_DB_STATEMENT
value: "true"
- name: OTEL_BSP_SCHEDULE_DELAY
value: "60000"
resources: {}
securityContext:
runAsUser: 0
Expand Down
62 changes: 1 addition & 61 deletions internal/test/e2e/kafka-go/traces.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,67 +137,7 @@
"spanId": "xxxxx",
"status": {},
"traceId": "xxxxx"
}
]
}
]
},
{
"resource": {
"attributes": [
{
"key": "process.runtime.description",
"value": {
"stringValue": "go version 1.23.0 linux/amd64"
}
},
{
"key": "process.runtime.name",
"value": {
"stringValue": "go"
}
},
{
"key": "process.runtime.version",
"value": {
"stringValue": "1.23.0"
}
},
{
"key": "service.name",
"value": {
"stringValue": "sample-app"
}
},
{
"key": "telemetry.distro.name",
"value": {
"stringValue": "opentelemetry-go-instrumentation"
}
},
{
"key": "telemetry.distro.version",
"value": {
"stringValue": "v0.14.0-alpha"
}
},
{
"key": "telemetry.sdk.language",
"value": {
"stringValue": "go"
}
}
]
},
"schemaUrl": "https://opentelemetry.io/schemas/1.26.0",
"scopeSpans": [
{
"schemaUrl": "https://opentelemetry.io/schemas/1.26.0",
"scope": {
"name": "go.opentelemetry.io/auto/github.com/segmentio/kafka-go",
"version": "v0.14.0-alpha"
},
"spans": [
},
{
"attributes": [
{
Expand Down
2 changes: 1 addition & 1 deletion internal/test/e2e/kafka-go/verify.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ SCOPE="go.opentelemetry.io/auto/github.com/segmentio/kafka-go"
@test "go-auto :: includes service.name in resource attributes" {
result=$(resource_attributes_received | jq "select(.key == \"service.name\").value.stringValue")
result_separated=$(echo $result | sed 's/\n/,/g')
assert_equal "$result_separated" '"sample-app" "sample-app"'
assert_equal "$result_separated" '"sample-app"'
}

@test "kafka producer,consumer :: valid {messaging.system} for all spans" {
Expand Down
Loading