Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Config Provider as an option to set the initial configuration and update it. #1010

Merged
merged 9 commits into from
Aug 20, 2024

Conversation

RonFed
Copy link
Contributor

@RonFed RonFed commented Aug 18, 2024

This PR adds a config.Provider interface which supplies an initial configuration and allows modification of the instrumentation configuration in runtime.
Currently, the configuration includes:

  • enable/disable of each instrumentation library.
  • global default disable - which allows setting the default behavior for enabling/disabling instrumentations.

Future additions to the configuration might be:

  • Sampling
  • Collecting extra attributes which are not collected by default.

Future implementations of the Provider interface might include:

  • Providing initial configuration based on environment variables.
  • Providing initial configuration and updates based on a configuration file.

@RonFed RonFed marked this pull request as ready for review August 18, 2024 12:35
@RonFed RonFed requested a review from a team August 18, 2024 12:35
@edeNFed edeNFed merged commit 0902c70 into open-telemetry:main Aug 20, 2024
24 checks passed
minimAluminiumalism pushed a commit to minimAluminiumalism/opentelemetry-go-instrumentation that referenced this pull request Sep 9, 2024
…on and update it. (open-telemetry#1010)

* Add config.Provider to load/unload probes

* Added comments, improve log message and unit test

* update test file

* changleog entry

* rename config fields to be traces specific

* Hadle potential races between applying config and closing

* clarigy shutdown function

---------

Co-authored-by: Eden Federman <[email protected]>
@MrAlias MrAlias added this to the v0.15.0-alpha milestone Oct 1, 2024
@MrAlias MrAlias mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants