Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add gin instrumentation #100

Merged
merged 27 commits into from
Apr 27, 2023
Merged

[feat] Add gin instrumentation #100

merged 27 commits into from
Apr 27, 2023

Conversation

MikeGoldsmith
Copy link
Member

@MikeGoldsmith MikeGoldsmith commented Apr 26, 2023 •
edited
Loading

Adds gin-gonic/gin instrumentation.

Includes new eBPF probe, instrumentor and e2e test.

@MikeGoldsmith MikeGoldsmith marked this pull request as ready for review April 26, 2023 14:10
@MikeGoldsmith MikeGoldsmith requested a review from a team April 26, 2023 14:10
damemi
damemi reviewed Apr 26, 2023
View reviewed changes
test/e2e/gin/main.go Outdated Show resolved Hide resolved
@MikeGoldsmith MikeGoldsmith mentioned this pull request Apr 26, 2023
Closed
2 tasks
MrAlias
MrAlias reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. Just some minor cleanup needed.

test/e2e/gin/go.mod Outdated Show resolved Hide resolved
pkg/instrumentors/bpf/github.com/gin-gonic/gin/probe.go Outdated Show resolved Hide resolved
pkg/instrumentors/bpf/github.com/gin-gonic/gin/probe.go Show resolved Hide resolved
MikeGoldsmith and others added 3 commits April 27, 2023 15:03
@MikeGoldsmith @MrAlias
Update test/e2e/gin/go module name
b1f985f 
Co-authored-by: Tyler Yahn <[email protected]>
@MikeGoldsmith @MrAlias
update probe go package name
563a4e5 
Co-authored-by: Tyler Yahn <[email protected]>
@MikeGoldsmith
Merge branch 'main' of github.com:open-telemetry/opentelemetry-go-ins…
77fc3dd 
…trumentation into mike/gin-instr

# Conflicts:
#	Makefile
@MikeGoldsmith
Copy link
Member Author

@MrAlias I've updated the things you suggested - ready for another review 👍🏻

@MikeGoldsmith
Copy link
Member Author

MikeGoldsmith commented Apr 27, 2023 •
edited
Loading

Strange, the grpc probe's now complaining of incorrect variable types (s32 -> void*). Those were just warnings.

The real issue was a rename of two fields on bpffs. Should be fixed now.

@MrAlias MrAlias merged commit 7cfaca8 into open-telemetry:main Apr 27, 2023
@MikeGoldsmith MikeGoldsmith deleted the mike/gin-instr branch April 27, 2023 20:25
This was referenced Apr 27, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias MrAlias approved these changes

@damemi damemi damemi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add gin-gonic instrumentation
3 participants
@MikeGoldsmith @damemi @MrAlias