Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement slog Handler Enabled #5315

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Implement slog Handler Enabled #5315

merged 3 commits into from
Mar 20, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 19, 2024

Part of #5195

@MrAlias MrAlias added Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG bridge: slog Related to the slog bridge labels Mar 19, 2024
@MrAlias MrAlias force-pushed the impl-slog-enabled branch from 635a58d to 468cbd1 Compare March 19, 2024 20:42
@codecov Codecov
Copy link

codecov bot commented Mar 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.2%. Comparing base (aba0417) to head (ea983c2).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5315   +/-   ##
=====================================
  Coverage   61.1%   61.2%           
=====================================
  Files        186     186           
  Lines      11228   11231    +3     
=====================================
+ Hits        6865    6875   +10     
+ Misses      4163    4156    -7     
  Partials     200     200
Files Coverage Δ
bridges/otelslog/handler.go 33.3% <100.0%> (+33.3%) ⬆️

... and 1 file with indirect coverage changes

@MrAlias MrAlias marked this pull request as ready for review March 19, 2024 20:44
@MrAlias MrAlias requested a review from a team March 19, 2024 20:44
@MrAlias MrAlias merged commit 10c1eea into open-telemetry:main Mar 20, 2024
23 checks passed
@MrAlias MrAlias deleted the impl-slog-enabled branch March 20, 2024 20:38
zailic pushed a commit to zailic/opentelemetry-go-contrib that referenced this pull request Mar 27, 2024
@MrAlias @zailic
Implement slog Handler Enabled (open-telemetry#5315)
3dcca6d 
* Implement slog Handler Enabled

* Comment MinSeverity field

* Run go mod tidy
@MrAlias MrAlias added this to the v1.25.0 milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@dashpole dashpole dashpole approved these changes

@dmathieu dmathieu dmathieu approved these changes

Assignees
No one assigned
Labels
bridge: slog Related to the slog bridge Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
Go: Logs (GA)
Status: Done
Milestone
v1.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MrAlias @dmathieu @dashpole @pellared