Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelgrpc: Remove code that has no effects in stats handlers #4773

Merged
merged 13 commits into from
Jan 4, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Dec 28, 2023

The span returned in TagConn is always noop.
The ctx in TagConn and TagRPC are different.

Related to #4531

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f770d88) 81.1% compared to head (2f1c89a) 81.1%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4773     +/-   ##
=======================================
- Coverage   81.1%   81.1%   -0.1%     
=======================================
  Files        150     150             
  Lines      10759   10753      -6     
=======================================
- Hits        8731    8725      -6     
  Misses      1872    1872             
  Partials     156     156             
Files Coverage Δ
...n/google.golang.org/grpc/otelgrpc/stats_handler.go 92.8% <100.0%> (-0.3%) ⬇️

@pellared pellared marked this pull request as ready for review December 28, 2023 19:49
@pellared pellared requested a review from a team December 28, 2023 19:49
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Damien Mathieu <[email protected]>
CHANGELOG.md Outdated Show resolved Hide resolved
@pellared pellared requested a review from MrAlias January 2, 2024 16:50
@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Jan 4, 2024
@pellared pellared merged commit f16553c into open-telemetry:main Jan 4, 2024
23 of 24 checks passed
@pellared pellared deleted the cleanup-otelgrpc-stats branch January 4, 2024 07:54
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants