Upgrade Exporter to match new API #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marwan-at-work
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
paivagustavo
as code owners
MrAlias
approved these changes
May 28, 2020
jmacd
approved these changes
May 28, 2020
jmacd
reviewed
May 28, 2020
|
I'm pretty sure this was superseded by #53 |
|
This contains a change to address a TODO about using the resource values. |
|
Address feedback to have labels override resource attributes.
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* add IsValid() for SpanContext * add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the datadog exporter and also uses the Resource:
cc @jmacd I am combining both the Resource and the record's LabelSet(). I'm hoping that this the correct way to accumulate tags, but definitely let me know otherwise.
Thanks!