Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Prometheus exporter #4479

Merged
merged 17 commits into from
Oct 31, 2023
Merged

Add support for Prometheus exporter #4479

merged 17 commits into from
Oct 31, 2023

Conversation

punya
Copy link
Member

@punya punya commented Oct 24, 2023

Fixes #4472

@punya punya requested a review from pellared as a code owner October 24, 2023 18:21
@punya punya requested a review from a team October 24, 2023 18:21
@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #4479 (e877189) into main (724a94b) will increase coverage by 0.0%.
The diff coverage is 87.2%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4479   +/-   ##
=====================================
  Coverage   80.8%   80.9%           
=====================================
  Files        150     150           
  Lines      10245   10292   +47     
=====================================
+ Hits        8284    8327   +43     
- Misses      1823    1825    +2     
- Partials     138     140    +2
Files Coverage Δ
exporters/autoexport/metrics.go 81.8% <87.2%> (+8.4%) ⬆️

... and 1 file with indirect coverage changes

@punya
Actually add Prometheus handler
4875a19 
Wow that was embarrassing
dashpole
dashpole reviewed Oct 25, 2023
View reviewed changes
exporters/autoexport/metrics.go Outdated Show resolved Hide resolved
exporters/autoexport/metrics.go Outdated Show resolved Hide resolved
exporters/autoexport/metrics.go Outdated Show resolved Hide resolved
pellared
pellared reviewed Oct 25, 2023
View reviewed changes
exporters/autoexport/metrics.go Outdated Show resolved Hide resolved
exporters/autoexport/metrics_test.go Show resolved Hide resolved
exporters/autoexport/metrics.go Outdated Show resolved Hide resolved
pellared
pellared reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the last comments from my side.

exporters/autoexport/metrics.go Outdated Show resolved Hide resolved
exporters/autoexport/metrics.go Outdated Show resolved Hide resolved
exporters/autoexport/metrics.go Outdated Show resolved Hide resolved
exporters/autoexport/metrics.go Outdated Show resolved Hide resolved
pellared
pellared reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that doc comment for NewMetricReader needs to be updated.

@pellared
Copy link
Member

Nice work 👍 I plan to merge it on Monday to give others chance to review.

@punya
Copy link
Member Author

punya commented Oct 27, 2023

Thanks for the detailed review @pellared.

@pellared pellared merged commit bead7e4 into open-telemetry:main Oct 31, 2023
21 checks passed
@pellared pellared mentioned this pull request Nov 10, 2023
Merged
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@dashpole dashpole dashpole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

autoexport: Add support for Prometheus
3 participants
@punya @pellared @dashpole